<html>
<head><meta charset="utf-8"><title>Issue 7992/Contributor processs · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/Issue.207992.2FContributor.20processs.html">Issue 7992/Contributor processs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="242154568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/Issue%207992/Contributor%20processs/near/242154568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Francis Nixon <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/Issue.207992.2FContributor.20processs.html#242154568">(Jun 10 2021 at 02:57)</a>:</h4>
<p>I want to tackle: <a href="https://github.com/rust-lang/cargo/issues/7992">https://github.com/rust-lang/cargo/issues/7992</a> as it is an issue at my job.  Would such a fix get merged? At first look it seems that cargo uses the servo url crate, and the url crate or usage of it might need to change(Haven't looked in depth yet I might be able to completely avoid this). But assuming that I would have to make more substantial changes to the usage of the url crate, how should I approach that? If I need large changes should I make an RFC?</p>



<a name="242156434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/Issue%207992/Contributor%20processs/near/242156434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/Issue.207992.2FContributor.20processs.html#242156434">(Jun 10 2021 at 03:40)</a>:</h4>
<p>Hi <span class="user-mention" data-user-id="410712">@Francis Nixon</span> .  I don't have the context in memory right now, but IIRC the issue is that cargo doesn't handle relative submodules at all?  And it seems like all it needs to do is join the parent's URL with the relative path (if it starts with <code>./</code> or <code>../</code>?  That seems like it should be a relatively small fix inside cargo.  </p>
<p>I think the fix would go <a href="https://github.com/rust-lang/cargo/blob/b3475e6df9f9d0b3e61c84a5746f7dc872368637/src/cargo/sources/git/utils.rs#L363-L418">around here</a> where it would just need to call <code>.join()</code> on the parent's url with the child's if it is relative.  Not sure if the parent URL is readily available there, but I imagine it can be passed in if not.</p>
<p>For contributing to cargo, there is a guide <a href="https://doc.crates.io/contrib/">here</a> with information on how to get started and how to run and write tests.</p>



<a name="242156446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/Issue%207992/Contributor%20processs/near/242156446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/Issue.207992.2FContributor.20processs.html#242156446">(Jun 10 2021 at 03:41)</a>:</h4>
<p>And I think a PR with the fix is all that is needed, we usually don't use RFCs for code changes or fixes.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>